https://github.com/jeffreytan81 requested changes to this pull request.
@augusto2112, sorry, our company does not use email as primary work communication channel so this PR got missed in overwhelming number of other auto-notification emails. I am pretty sure the deletion of `ClearNextBranchBreakpoint` is not accidental. The new design is making `NextRangeBreakpointExplainsStop()` a pretty side-effect free checking -- only check if the `stop_info_sp` is an internal "next range breakpoint" stop or not without removing it. And this internal "next range breakpoint" clean up has been moved into `ClearNextBranchBreakpointExplainedStop()` during each ThreadPlan's StopShould(). The comment can be left-over that should be removed. I remember this change is important because in original PR's ThreadPlanSingleThreadTimeout workflow `NextRangeBreakpointExplainsStop` can be called multiple times or some ordering, which can cause later checking to fail? There is a test for `ThreadPlanSingleThreadTimeout` but it's unfortunate it did not fail with `ClearNextBranchBreakpoint()` adding back. I have no idea why though. Do you have a scenario that requires `ClearNextBranchBreakpoint` otherwise it is failing? https://github.com/llvm/llvm-project/pull/161597 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
