tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land.
LGTM, assuming that it works on all 3 OSes ================ Comment at: packages/Python/lldbsuite/test/make/Android.rules:1 +NDK_ROOT := $(shell dirname $(CC))/../../../../.. +NDK_ROOT := $(realpath $(NDK_ROOT)) ---------------- Will this file work on Windows (e.g. dirname, realpath, forward slash)? ================ Comment at: packages/Python/lldbsuite/test/make/Android.rules:4-13 +ifeq "$(findstring $(ARCH), aarch64 x86_64)" "$(ARCH)" + # lowest 64-bit API level + API_LEVEL := 21 +else ifeq "$(ARCH)" "i386" + # clone(2) declaration is present only since this api level + API_LEVEL := 17 +else ---------------- Does it make sense to use a different API level for every architecture? I think making it somewhat consistent would make it easier to use it https://reviews.llvm.org/D30410 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
