================
@@ -501,7 +501,9 @@ lldb::FunctionSP 
SymbolFileNativePDB::CreateFunction(PdbCompilandSymId func_id,
     return nullptr;
 
   PdbTypeSymId sig_id(proc.FunctionType, false);
-  Mangled mangled(proc.Name);
+  auto mangled_opt =
----------------
Michael137 wrote:

nit:
```suggestion
  std::optional<llvm::StringRef> mangled_opt =
```
Where it's not immediately obvious what the type is we usually avoid `auto`

https://github.com/llvm/llvm-project/pull/149701
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to