DavidSpickett wrote:

I forgot all about https://github.com/llvm/llvm-project/pull/157435 so I just 
merged it and you'll have conflicts from that.

You don't have to make the test work on Linux, `if Darwin` is fine and extend 
it later.

In an ideal world, we would know that the target has memory tagging enabled and 
only then leave the tag in. Though given that MTE implies TBI and we have TBI 
everywhere we care about, we won't fault leaving in the tag bits on a system 
without MTE.

So what you've got is fine, assuming you have at least TBI on all systems 
you're gonna use this with.

I do wonder if this is gonna work for any AArch64 target, because there can be 
targets where you need to remove PAC codes but you don't have top byte ignore. 
Anyway I'll think about that.

> FixAnyAddressPreservingAuthentication

Authentication is an awkward word choice considering that it removes Pointer 
Authentication Codes.

Don't have a better suggestion off the top of my head.

https://github.com/llvm/llvm-project/pull/159785
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to