royitaqi wrote: @JDevlieghere, @walter-erquinigo: I have updated the patch according to your suggestions. LMK if it looks alright.
Changes: 1. Rename the option to `--connection-timeout`. 2. Print a warning and exit lldb-dap when `--connection-timeout` is given and `--connection` isn't. 3. Add an extension setting (similar to `Server Mode`) and pass that down to `--connection-timeout` when starting the server. 4. Add api tests. Caveats: * The existing tests in `TestDAP_server.py` don't test with concurrent clients. My newly added tests don't either. * Wanted to update `lldb/tools/lldb-dap/README.md`, but realize that the "Server Mode" isn't mentioned there. @walter-erquinigo LMK if you want me to add a section to mention both (if so, where in the doc and suggestive new section name?). https://github.com/llvm/llvm-project/pull/156803 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
