labath added a comment.
I think you are still waiting to get the llvm changes sorted out, but this side
of it looks fine to me (modulo a couple of nits).
================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:414
+
+ data_sp = std::make_shared<DataBufferLLVM>(std::move(*Buffer));
+ data_offset = 0;
----------------
It looks like this make-a-MemoryBuffer-and-shove-it-in-a-DataBufferLLVM
functionality could be handled by a utility function, as it is used in a number
of places.
================
Comment at: lldb/unittests/Process/minidump/MinidumpParserTest.cpp:54
llvm::sys::path::append(filename, minidump_filename);
FileSpec minidump_file(filename.c_str(), false);
+
----------------
It looks like this variable is not necessary anymore.
https://reviews.llvm.org/D30054
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
