labath added a comment.

It does not seem too controversial, but I am not very confident reviewing lit 
changes. @beanz, could you take a look at this?



================
Comment at: lit/lit.cfg:124
 
-debugserver = lit.util.which('debugserver', llvm_tools_dir)
-lldb = lit.util.which('lldb', llvm_tools_dir)
+debugserver = lit.util.which('debugserver', config.environment['PATH'])
+lldb = lit.util.which('lldb', config.environment['PATH'])
----------------
Wouldn't it be better to use lldb_tools_dir instead of the PATH here? Less 
chance to pick up the wrong tool accidentally?


Repository:
  rL LLVM

https://reviews.llvm.org/D29985



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to