Author: Abdullah Mohammad Amin Date: 2025-08-29T16:23:07+01:00 New Revision: 599d353938f52457b7c7e1ab7f223132bb353370
URL: https://github.com/llvm/llvm-project/commit/599d353938f52457b7c7e1ab7f223132bb353370 DIFF: https://github.com/llvm/llvm-project/commit/599d353938f52457b7c7e1ab7f223132bb353370.diff LOG: [lldb] Restrict TestVariableAnnotationsDisassembler.py to ELF x86_64 (skip on Windows/COFF) (#156026) The `TestVariableAnnotationsDisassembler.py` test assembles `d_original_example.s`, which contains ELF-specific directives such as: - `.ident` - `.section ".note.GNU-stack", "", @progbits` - `.section .debug_line, "", @progbits` These directives are not understood by COFF on Windows, so the test fails on the lldb-remote-linux-win builder even when running on x86_64. This patch adds a decorator to gate the test, - `@skipUnlessPlatform(["linux", "freebsd", "netbsd", "android"])` — runs only on ELF platforms Follow-up to #155942. Added: Modified: lldb/test/API/functionalities/disassembler-variables/TestVariableAnnotationsDisassembler.py Removed: ################################################################################ diff --git a/lldb/test/API/functionalities/disassembler-variables/TestVariableAnnotationsDisassembler.py b/lldb/test/API/functionalities/disassembler-variables/TestVariableAnnotationsDisassembler.py index 4d99ea771605a..f107efbddddeb 100644 --- a/lldb/test/API/functionalities/disassembler-variables/TestVariableAnnotationsDisassembler.py +++ b/lldb/test/API/functionalities/disassembler-variables/TestVariableAnnotationsDisassembler.py @@ -5,6 +5,9 @@ import re +# Requires ELF assembler directives (.section … @progbits, .ident, etc.); +# not compatible with COFF/Mach-O toolchains. +@skipUnlessPlatform(["linux", "android", "freebsd", "netbsd"]) class TestVariableAnnotationsDisassembler(TestBase): def _build_obj(self, obj_name: str) -> str: # Let the Makefile build all .o’s (pattern rule). Then grab the one we need. _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
