================
@@ -51,6 +55,23 @@ bool RegisterContextCorePOSIX_arm::ReadRegister(const
RegisterInfo *reg_info,
return true;
}
}
+
+ const uint32_t reg = reg_info->kinds[lldb::eRegisterKindLLDB];
+ if (reg == LLDB_INVALID_REGNUM)
+ return false;
----------------
DavidSpickett wrote:
This logic does work, if `(offset == reg_info->byte_offset +
reg_info->byte_size)` is False, it'll get here, maybe get a regnum and then
fail `IsFPR`.
However, it looks a lot like we forgot a return earlier.
I wonder if there is `IsGPR` we could use instead of the offset check. Then
it's:
* try to get a regnum
* is it gpr?
* else is it fpr?
Which is easier to follow.
https://github.com/llvm/llvm-project/pull/155956
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
