jimingham wrote: > Regarding capitalization, I pretty strongly prefer **not** to change it and > focus on highlighting the mnemonic. Here's why: > > * I don't think that matching the capitalization was ever the goal, but > rather capitalization was used to highlight the letter, regardless of whether > the short option was actually capitalized. Now the same thing is achieved > through an underline. > * I think the capitalization of the short option is much less important than > the mnemonic aspect. If the option is `-W` and I see an underlined `w`, it > doesn't take much mental overhead to piece the two together. Similar to the > above, I don't think the goal was to be able to read the help text and figure > out the exact option without having to look at the line above with the short > and long option. > * If we do change the capitalization, we're back to the original problem when > someone runs lldb without color (or if we end up detangling the two, without > escape codes) where this looks like a typo. Even with the underline, users > might still think it's a typo. > > @DavidSpickett @kastiglione let me know if you folks feel differently or have > an alternative suggestion.
I'm fine with this option. The purpose was to help make the letter we're choosing for the short option stick in people's minds a bit when they look at the help output. underlining the letter does that all the way for lower case and gets close enough for upper case short options to be useful without making the output look weird. https://github.com/llvm/llvm-project/pull/153695 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
