DavidSpickett wrote: > Can you elaborate on what that program is showing and how this PR would > affect that?
That function, when called with a pointer to a pointer written to memory with WritePointerToMemory, would check whether that pointer had retained it's non-address bits. Without this change, it would see the non-address bits. With this change it would not. (which is unrelated to the host/debugee problem the reland is also fixing) I'm not sure how to craft an expression that will hit WritePointerToMemory though. Maybe you could use API calls to trigger WritePointerToMemory, then run an expression using the address it was written to. In other words: * Write a tagged pointer to memory via. WritePointerToMemory. * Run an expression that calls the check function, passing the address of where that pointer is stored. * If the check function sees non-address bits set, this PR is not working. * If it does not, this PR is working as expected. By doing the check using code in the debugee, you make sure that no other fix address call can get in the way. And if you change the strategy later, the test will break and remind us to change this particular call to fix address. https://github.com/llvm/llvm-project/pull/153585 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
