clayborg added inline comments.
================
Comment at: source/Target/SectionLoadList.cpp:70
bool warn_multiple) {
- Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER |
- LIBLLDB_LOG_VERBOSE));
-
+ Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER));
ModuleSP module_sp(section->GetModule());
----------------
labath wrote:
> zturner wrote:
> > There's a subtle behavioral change here, which is that previously this line
> > would get logged even if `LIBLLDB_LOG_DYNAMIC_LOADER` was not set, and now
> > it won't. However, I've always found the `GetLogIfAny` / `GetLogIfAll`
> > split unnecessarily confusing, so I'm not opposed to this change. Just
> > want to point it out.
> You're right I didn't notice that. However, I suspect that this was actually
> not intended, so it should be fine. It'd be interesting to see how many calls
> to IfAny/IfAll we have with more than one category after this change.
The previous usage was incorrect indeed. It should have been IfAll. IfAny only
works when you might have something that should be logged for say "process" or
for "thread". Then IfAny makes sense. Never makes sense to use IfAny with one
any flag and verbose...
https://reviews.llvm.org/D29510
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
