Derp. Thanks for catching that!
On Wed, Feb 1, 2017 at 2:41 PM Jason Molenda <jmole...@apple.com> wrote:
> You need some break;s.
>
>
> -const char *lldb_private::GetVoteAsCString(Vote vote) {
> - switch (vote) {
> - case eVoteNo:
> - return "no";
> - case eVoteNoOpinion:
> - return "no opinion";
> - case eVoteYes:
> - return "yes";
> - }
> - return "invalid";
> -}
>
>
> +template <> struct format_provider<lldb_private::Vote> {
> + static void format(const lldb_private::Vote &V, llvm::raw_ostream
> &Stream,
> + StringRef Style) {
> + switch (V) {
> + case lldb_private::eVoteNo:
> + Stream << "no";
> + case lldb_private::eVoteNoOpinion:
> + Stream << "no opinion";
> + case lldb_private::eVoteYes:
> + Stream << "yes";
> + }
> + Stream << "invalid";
> + }
>
>
>
>
> > On Feb 1, 2017, at 2:33 PM, Zachary Turner via Phabricator via
> lldb-commits <lldb-commits@lists.llvm.org> wrote:
> >
> > zturner created this revision.
> > Herald added subscribers: mgorny, nemanjai, srhines, danalbert, emaste.
> >
> > NFC here, this only moves `ConstString`, `Error`, `RegularExpression`,
> `Stream`, and `StreamString` from `Core` to `Utility`. The CL is large
> because these headers are included in many places, so it required updating
> every include to point to the new location.
> >
> > This change isn't very controversial, but it will require an update of
> the Xcode project. We can do that now so that I can submit this in one
> large patch, or I can just go in with this and someone can fix up the Xcode
> project later. LMK what is preferred.
> >
> >
> > https://reviews.llvm.org/D29427
> >
> > Files:
> > lldb/include/lldb/Breakpoint/BreakpointResolver.h
> > lldb/include/lldb/Breakpoint/BreakpointResolverFileRegex.h
> > lldb/include/lldb/Core/AddressResolver.h
> > lldb/include/lldb/Core/AddressResolverName.h
> > lldb/include/lldb/Core/ArchSpec.h
> > lldb/include/lldb/Core/Broadcaster.h
> > lldb/include/lldb/Core/Communication.h
> > lldb/include/lldb/Core/ConstString.h
> > lldb/include/lldb/Core/DataBufferMemoryMap.h
> > lldb/include/lldb/Core/Error.h
> > lldb/include/lldb/Core/Event.h
> > lldb/include/lldb/Core/FormatEntity.h
> > lldb/include/lldb/Core/IOHandler.h
> > lldb/include/lldb/Core/Log.h
> > lldb/include/lldb/Core/Mangled.h
> > lldb/include/lldb/Core/MappedHash.h
> > lldb/include/lldb/Core/ModuleSpec.h
> > lldb/include/lldb/Core/RegularExpression.h
> > lldb/include/lldb/Core/Section.h
> > lldb/include/lldb/Core/Stream.h
> > lldb/include/lldb/Core/StreamAsynchronousIO.h
> > lldb/include/lldb/Core/StreamBuffer.h
> > lldb/include/lldb/Core/StreamCallback.h
> > lldb/include/lldb/Core/StreamFile.h
> > lldb/include/lldb/Core/StreamGDBRemote.h
> > lldb/include/lldb/Core/StreamString.h
> > lldb/include/lldb/Core/StreamTee.h
> > lldb/include/lldb/Core/StructuredData.h
> > lldb/include/lldb/Core/UniqueCStringMap.h
> > lldb/include/lldb/Core/UserSettingsController.h
> > lldb/include/lldb/Core/Value.h
> > lldb/include/lldb/Core/ValueObject.h
> > lldb/include/lldb/DataFormatters/DataVisualization.h
> > lldb/include/lldb/DataFormatters/FormatCache.h
> > lldb/include/lldb/DataFormatters/FormattersContainer.h
> > lldb/include/lldb/DataFormatters/TypeSummary.h
> > lldb/include/lldb/DataFormatters/VectorIterator.h
> > lldb/include/lldb/Expression/DWARFExpression.h
> > lldb/include/lldb/Expression/ExpressionParser.h
> > lldb/include/lldb/Expression/ExpressionVariable.h
> > lldb/include/lldb/Expression/IRInterpreter.h
> > lldb/include/lldb/Expression/Materializer.h
> > lldb/include/lldb/Host/FileCache.h
> > lldb/include/lldb/Host/FileSpec.h
> > lldb/include/lldb/Host/FileSystem.h
> > lldb/include/lldb/Host/HostNativeProcessBase.h
> > lldb/include/lldb/Host/HostNativeThreadBase.h
> > lldb/include/lldb/Host/HostThread.h
> > lldb/include/lldb/Host/LockFileBase.h
> > lldb/include/lldb/Host/MainLoopBase.h
> > lldb/include/lldb/Host/PipeBase.h
> > lldb/include/lldb/Host/Socket.h
> > lldb/include/lldb/Host/ThreadLauncher.h
> > lldb/include/lldb/Host/XML.h
> > lldb/include/lldb/Host/common/NativeBreakpointList.h
> > lldb/include/lldb/Host/common/NativeProcessProtocol.h
> > lldb/include/lldb/Host/common/NativeWatchpointList.h
> > lldb/include/lldb/Host/posix/HostProcessPosix.h
> > lldb/include/lldb/Interpreter/Args.h
> > lldb/include/lldb/Interpreter/CommandCompletions.h
> > lldb/include/lldb/Interpreter/CommandHistory.h
> > lldb/include/lldb/Interpreter/CommandObjectRegexCommand.h
> > lldb/include/lldb/Interpreter/CommandReturnObject.h
> > lldb/include/lldb/Interpreter/OptionGroupPlatform.h
> > lldb/include/lldb/Interpreter/OptionValue.h
> > lldb/include/lldb/Interpreter/OptionValueEnumeration.h
> > lldb/include/lldb/Interpreter/OptionValueProperties.h
> > lldb/include/lldb/Interpreter/OptionValueRegex.h
> > lldb/include/lldb/Interpreter/Property.h
> > lldb/include/lldb/Interpreter/ScriptInterpreter.h
> > lldb/include/lldb/Symbol/Block.h
> > lldb/include/lldb/Symbol/ClangASTContext.h
> > lldb/include/lldb/Symbol/CompileUnit.h
> > lldb/include/lldb/Symbol/CompilerDecl.h
> > lldb/include/lldb/Symbol/CompilerDeclContext.h
> > lldb/include/lldb/Symbol/DebugMacros.h
> > lldb/include/lldb/Symbol/GoASTContext.h
> > lldb/include/lldb/Symbol/JavaASTContext.h
> > lldb/include/lldb/Symbol/OCamlASTContext.h
> > lldb/include/lldb/Symbol/Type.h
> > lldb/include/lldb/Symbol/UnwindPlan.h
> > lldb/include/lldb/Target/ABI.h
> > lldb/include/lldb/Target/DynamicLoader.h
> > lldb/include/lldb/Target/MemoryRegionInfo.h
> > lldb/include/lldb/Target/PathMappingList.h
> > lldb/include/lldb/Target/Platform.h
> > lldb/include/lldb/Target/Process.h
> > lldb/include/lldb/Target/QueueItem.h
> > lldb/include/lldb/Target/StackFrame.h
> > lldb/include/lldb/Target/SystemRuntime.h
> > lldb/include/lldb/Target/UnixSignals.h
> > lldb/include/lldb/Utility/ConstString.h
> > lldb/include/lldb/Utility/Error.h
> > lldb/include/lldb/Utility/JSON.h
> > lldb/include/lldb/Utility/ProcessStructReader.h
> > lldb/include/lldb/Utility/RegularExpression.h
> > lldb/include/lldb/Utility/Stream.h
> > lldb/include/lldb/Utility/StreamString.h
> > lldb/include/lldb/Utility/StreamTee.h
> > lldb/source/API/SBAddress.cpp
> > lldb/source/API/SBBreakpoint.cpp
> > lldb/source/API/SBBreakpointLocation.cpp
> > lldb/source/API/SBCommandReturnObject.cpp
> > lldb/source/API/SBData.cpp
> > lldb/source/API/SBDeclaration.cpp
> > lldb/source/API/SBError.cpp
> > lldb/source/API/SBEvent.cpp
> > lldb/source/API/SBFileSpec.cpp
> > lldb/source/API/SBFileSpecList.cpp
> > lldb/source/API/SBFrame.cpp
> > lldb/source/API/SBInstructionList.cpp
> > lldb/source/API/SBLineEntry.cpp
> > lldb/source/API/SBListener.cpp
> > lldb/source/API/SBMemoryRegionInfo.cpp
> > lldb/source/API/SBModule.cpp
> > lldb/source/API/SBModuleSpec.cpp
> > lldb/source/API/SBPlatform.cpp
> > lldb/source/API/SBProcess.cpp
> > lldb/source/API/SBSection.cpp
> > lldb/source/API/SBSourceManager.cpp
> > lldb/source/API/SBStream.cpp
> > lldb/source/API/SBStructuredData.cpp
> > lldb/source/API/SBTarget.cpp
> > lldb/source/API/SBThread.cpp
> > lldb/source/API/SBThreadPlan.cpp
> > lldb/source/API/SBType.cpp
> > lldb/source/API/SBTypeEnumMember.cpp
> > lldb/source/API/SBValue.cpp
> > lldb/source/API/SBWatchpoint.cpp
> > lldb/source/Breakpoint/Breakpoint.cpp
> > lldb/source/Breakpoint/BreakpointID.cpp
> > lldb/source/Breakpoint/BreakpointLocation.cpp
> > lldb/source/Breakpoint/BreakpointOptions.cpp
> > lldb/source/Breakpoint/BreakpointResolver.cpp
> > lldb/source/Breakpoint/BreakpointResolverAddress.cpp
> > lldb/source/Breakpoint/BreakpointResolverFileLine.cpp
> > lldb/source/Breakpoint/BreakpointResolverFileRegex.cpp
> > lldb/source/Breakpoint/BreakpointResolverName.cpp
> > lldb/source/Breakpoint/BreakpointSite.cpp
> > lldb/source/Breakpoint/BreakpointSiteList.cpp
> > lldb/source/Breakpoint/Watchpoint.cpp
> > lldb/source/Breakpoint/WatchpointOptions.cpp
> > lldb/source/Commands/CommandObjectBreakpoint.cpp
> > lldb/source/Commands/CommandObjectFrame.cpp
> > lldb/source/Commands/CommandObjectLog.cpp
> > lldb/source/Commands/CommandObjectMemory.cpp
> > lldb/source/Commands/CommandObjectType.cpp
> > lldb/source/Commands/CommandObjectWatchpoint.cpp
> > lldb/source/Core/AddressRange.cpp
> > lldb/source/Core/AddressResolver.cpp
> > lldb/source/Core/AddressResolverFileLine.cpp
> > lldb/source/Core/AddressResolverName.cpp
> > lldb/source/Core/ArchSpec.cpp
> > lldb/source/Core/Baton.cpp
> > lldb/source/Core/Broadcaster.cpp
> > lldb/source/Core/CMakeLists.txt
> > lldb/source/Core/ConstString.cpp
> > lldb/source/Core/DataBufferMemoryMap.cpp
> > lldb/source/Core/DataExtractor.cpp
> > lldb/source/Core/Debugger.cpp
> > lldb/source/Core/Disassembler.cpp
> > lldb/source/Core/EmulateInstruction.cpp
> > lldb/source/Core/Error.cpp
> > lldb/source/Core/Event.cpp
> > lldb/source/Core/FileLineResolver.cpp
> > lldb/source/Core/FileSpecList.cpp
> > lldb/source/Core/FormatEntity.cpp
> > lldb/source/Core/History.cpp
> > lldb/source/Core/Listener.cpp
> > lldb/source/Core/Log.cpp
> > lldb/source/Core/Mangled.cpp
> > lldb/source/Core/Module.cpp
> > lldb/source/Core/Opcode.cpp
> > lldb/source/Core/PluginManager.cpp
> > lldb/source/Core/RegisterValue.cpp
> > lldb/source/Core/RegularExpression.cpp
> > lldb/source/Core/Scalar.cpp
> > lldb/source/Core/SourceManager.cpp
> > lldb/source/Core/Stream.cpp
> > lldb/source/Core/StreamFile.cpp
> > lldb/source/Core/StreamString.cpp
> > lldb/source/Core/StringList.cpp
> > lldb/source/Core/StructuredData.cpp
> > lldb/source/Core/Timer.cpp
> > lldb/source/Core/UUID.cpp
> > lldb/source/Core/UserID.cpp
> > lldb/source/Core/UserSettingsController.cpp
> > lldb/source/Core/VMRange.cpp
> > lldb/source/Core/Value.cpp
> > lldb/source/Core/ValueObject.cpp
> > lldb/source/DataFormatters/CXXFunctionPointer.cpp
> > lldb/source/DataFormatters/FormattersHelpers.cpp
> > lldb/source/DataFormatters/StringPrinter.cpp
> > lldb/source/DataFormatters/TypeFormat.cpp
> > lldb/source/DataFormatters/TypeSummary.cpp
> > lldb/source/DataFormatters/TypeSynthetic.cpp
> > lldb/source/DataFormatters/TypeValidator.cpp
> > lldb/source/DataFormatters/ValueObjectPrinter.cpp
> > lldb/source/Expression/DWARFExpression.cpp
> > lldb/source/Expression/DiagnosticManager.cpp
> > lldb/source/Expression/ExpressionSourceCode.cpp
> > lldb/source/Expression/IRDynamicChecks.cpp
> > lldb/source/Expression/IRInterpreter.cpp
> > lldb/source/Expression/IRMemoryMap.cpp
> > lldb/source/Expression/LLVMUserExpression.cpp
> > lldb/source/Expression/UserExpression.cpp
> > lldb/source/Expression/UtilityFunction.cpp
> > lldb/source/Host/common/Editline.cpp
> > lldb/source/Host/common/File.cpp
> > lldb/source/Host/common/FileSpec.cpp
> > lldb/source/Host/common/Host.cpp
> > lldb/source/Host/common/HostInfoBase.cpp
> > lldb/source/Host/common/MonitoringProcessLauncher.cpp
> > lldb/source/Host/common/NativeBreakpoint.cpp
> > lldb/source/Host/common/Socket.cpp
> > lldb/source/Host/common/SoftwareBreakpoint.cpp
> > lldb/source/Host/common/Symbols.cpp
> > lldb/source/Host/common/ThisThread.cpp
> > lldb/source/Host/freebsd/Host.cpp
> > lldb/source/Host/linux/Host.cpp
> > lldb/source/Host/macosx/Symbols.cpp
> > lldb/source/Host/netbsd/Host.cpp
> > lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp
> > lldb/source/Host/posix/FileSystem.cpp
> > lldb/source/Host/posix/HostThreadPosix.cpp
> > lldb/source/Host/posix/MainLoopPosix.cpp
> > lldb/source/Host/windows/ConnectionGenericFileWindows.cpp
> > lldb/source/Host/windows/Host.cpp
> > lldb/source/Host/windows/HostThreadWindows.cpp
> > lldb/source/Host/windows/ThisThread.cpp
> > lldb/source/Interpreter/Args.cpp
> > lldb/source/Interpreter/CommandAlias.cpp
> > lldb/source/Interpreter/CommandInterpreter.cpp
> > lldb/source/Interpreter/CommandReturnObject.cpp
> > lldb/source/Interpreter/OptionGroupVariable.cpp
> > lldb/source/Interpreter/OptionValueArray.cpp
> > lldb/source/Interpreter/OptionValueBoolean.cpp
> > lldb/source/Interpreter/OptionValueChar.cpp
> > lldb/source/Interpreter/OptionValueFileSpecLIst.cpp
> > lldb/source/Interpreter/OptionValueFormat.cpp
> > lldb/source/Interpreter/OptionValueFormatEntity.cpp
> > lldb/source/Interpreter/OptionValueLanguage.cpp
> > lldb/source/Interpreter/OptionValuePathMappings.cpp
> > lldb/source/Interpreter/OptionValueProperties.cpp
> > lldb/source/Interpreter/OptionValueRegex.cpp
> > lldb/source/Interpreter/OptionValueSInt64.cpp
> > lldb/source/Interpreter/OptionValueString.cpp
> > lldb/source/Interpreter/OptionValueUInt64.cpp
> > lldb/source/Interpreter/OptionValueUUID.cpp
> > lldb/source/Interpreter/Options.cpp
> > (272 more files...)
> >
> > <D29427.86722.patch>_______________________________________________
> > lldb-commits mailing list
> > lldb-commits@lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
>
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
