https://github.com/JDevlieghere requested changes to this pull request.
A few high-level issues with this PR: - It's using exceptions, while LLVM and LLDB build without exceptions. While it's possible to build LLVM with exceptions, you would've had to to do so explicitly? - This still doesn't conform to LLVM or LLDB's coding style, including the braces around single-line ifs that @DavidSpickett [mentioned](https://github.com/llvm/llvm-project/pull/150365#pullrequestreview-3050710020) in the other PR. I don't necessarily expect you to read the [LLVM Coding Standards](https://llvm.org/docs/CodingStandards.html) but at least look at the surrounding code. I also don't think this PR actually solves anything. It exposes existing settings through DAP. I don't think these particular settings warrant that, especially as the network issue isn't inherent to DAP. I didn't look at the original bug report in detail, but if network timeout is the issue, then something like negative cashing if the server isn't available instead of repeatedly timing out is a solution. I'm not saying that's the fix, just an example of a fix vs a bandaid. https://github.com/llvm/llvm-project/pull/150777 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
