labath added a comment. I like where this is going. I am not sure about a couple of details though. Please see comments.
================ Comment at: source/Breakpoint/CMakeLists.txt:32 + lldbPluginObjCLanguage + LLVMSupport ) ---------------- Shouldn't this be: `LINK_COMPONENTS Support`? I have a feeling that if you specify it this way, it will break LLVM_LINK_LLVM_DYLIB build. ================ Comment at: tools/lldb-server/CMakeLists.txt:63 +# few LLDB libraries directly. +if (NOT LLDB_EXPORT_ALL_SYMBOLS) + set(EXTRA_LLDB_LIBS ---------------- This seems wrong. lldb-server does not link to liblldb at all, so it's link line should not be affected by the LLDB_EXPORT_ALL_SYMBOLS setting. lldb-server links agains the .a files directly. https://reviews.llvm.org/D29333 _______________________________________________ lldb-commits mailing list [email protected] http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
