kuilpd wrote: `lldb-shell-subprocess` tests were failing because they add a setting `settings set symbols.enable-external-lookup false`, which disables resolving variables for compile units, but still marks them as resolved, so `stack_frame->GetSymbolContext(lldb::eSymbolContextCompUnit)` just doesn't do anything. I'm not sure if it's by design or not, but checking that `comp_unit` before accessing it avoids this issue, I guess I should have done that to begin with.
The other thing I noticed is that watchpoint command doesn't expect `frame->GetValueForVariableExpressionPath` to search for global variables [(CommandObjectWatchpoint.cpp:842-847)](https://github.com/llvm/llvm-project/blob/7bbb65c8fee605d7c875e495d7ce14f7700ce554/lldb/source/Commands/CommandObjectWatchpoint.cpp#L842), so it has a second step after that using `target->GetImages().FindGlobalVariables()`. But after this fix, DIL finds the global anyway using the same method, so that seconds step is unused now. Should we address this somehow? https://github.com/llvm/llvm-project/pull/147955 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
