labath wrote:

There are two failures:
- the libc++ pointer child is called `__ptr_`, not `pointer`. I think we should 
clone/rename the child so that the child has a consistent name. This could be 
particularly useful for writing other data formatters, which may want to 
dereference a shared_ptr without caring which stdlib implementation they are 
using.
- the libstdc++ child type is `std::goo<...>::type` instead of `int` in libc++. 
I think the libc++ implementation is better. The case for unification is 
slightly weaker here (people can always resolve the typedef manually), though 
I'd still do it if its easy enough.

https://github.com/llvm/llvm-project/pull/147141
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to