labath wrote:

Thanks for taking this on.

It looks like most of the new tests fail on libstdc++. The reasons are often 
trivial -- for example the shared_ptr test fails because the object has a 
children whose name is `pointer` and not `__ptr_` (I'd say the libstdc++ 
formatter is right here) Overall, this doesn't surprise me much, since we 
haven't tried to make sure our formatters present a consistent view of the 
objects (even though I think we should and I think it should be possible).

I'd probably do this one data structure at a time -- merge the tests and tweak 
the formatters so that they produce uniform output. Thankfully, today we at 
least have presubmits to test these out easily.

https://github.com/llvm/llvm-project/pull/146740
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to