================
@@ -299,6 +299,8 @@ def parseOptionsAndInitTestdirs():
     configuration.libcxx_library_dir = args.libcxx_library_dir
     configuration.cmake_build_type = args.cmake_build_type.lower()
 
+    configuration.target_triple = args.target_triple
+
----------------
labath wrote:

That's better, though it would be even better if we could run these tests even 
if msvcstl was not the default clang target (similar to how we can run libc++ 
tests even when clang targets libstdc++ by default). 

>From what I gather, this behavior is controlled by the target triple. Would 
>manually changing the target triple by appending something to CFLAGS (take 
>`self.dbg.GetSelectedPlatform().GetTriple()` and append "-msvc" or something) 
>be a terrible idea? (FWIW, 
>[this](https://github.com/llvm/llvm-project/blob/6dad1e87fb7a8de7033a315f5dd5d7c95dab32f6/lldb/packages/Python/lldbsuite/test/make/Makefile.rules#L371)
> is where we append libc++ flags.

https://github.com/llvm/llvm-project/pull/143177
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to