[Lldb-commits] [lldb] [lldb-dap] Fix flaky test (PR #145231)

[Ebuka Ezike via lldb-commits]

================
@@ -310,7 +310,7 @@ serveConnection(const Socket::SocketProtocol &protocol, 
const std::string &name,
                                     "DAP session (" + client_name +
                                         ") error: ");
       }
-
+      io->Close();
----------------
da-viper wrote:

Shoudn't this get closed via RAII when it is out of scope ? 
https://github.com/llvm/llvm-project/blob/1128a4fd2c3a70ba61eead2ce093a9c31aa2970e/lldb/source/Host/common/Socket.cpp#L173-L175

https://github.com/llvm/llvm-project/pull/145231
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits