================
@@ -22,8 +22,26 @@ Status SaveCoreOptions::SetPluginName(const char *name) {
}
if (!PluginManager::IsRegisteredObjectFilePluginName(name)) {
----------------
DavidSpickett wrote:
Does this actually check that the plugin can save a core file, or just that
it's an object file plugin? I suspect it's the latter. Which means you could
say ObjectFileElf, which can't save cores, and it would try to do so.
So you'd have a name that's "valid" for the first check, but doesn't show up in
the "valid values are".
This would be easy to test by doing that in a shell test. But if you're going
to fix that, do it in another PR.
https://github.com/llvm/llvm-project/pull/143126
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
