ashgti wrote: > I was trying to avoid putting JSON in the test because I find it hard to > maintain (your editor/IDE doesn't understand it's JSON, refactoring tools > don't work, no automatic formatting, etc) but if we think this is easier to > maintain (and means folks write more tests) then I'm all for it. I also > really like the checks for the parsing errors.
While updating the test for the 'DisassembledInstruction' type I noticed it handled the 'address' a bit poorly, so I updated that as well with some improved error reporting. https://github.com/llvm/llvm-project/pull/142510 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits