Author: David Spickett Date: 2025-05-22T09:48:31Z New Revision: c82b30c13463073b359695a83d1dc1b7fc1c8088
URL: https://github.com/llvm/llvm-project/commit/c82b30c13463073b359695a83d1dc1b7fc1c8088 DIFF: https://github.com/llvm/llvm-project/commit/c82b30c13463073b359695a83d1dc1b7fc1c8088.diff LOG: [lldb][lldb-dap] Disable assembly breakpoint test on Windows New test added by https://github.com/llvm/llvm-project/pull/139969. On Windows we need debug information to be able to break on the function (we don't need it for main, but I assume that's a special case). So disable the test on Windows. I tried a few tricks like making a global label in assembly, but that doesn't show up without debug info either. Added: Modified: lldb/test/API/tools/lldb-dap/breakpoint-assembly/TestDAP_breakpointAssembly.py Removed: ################################################################################ diff --git a/lldb/test/API/tools/lldb-dap/breakpoint-assembly/TestDAP_breakpointAssembly.py b/lldb/test/API/tools/lldb-dap/breakpoint-assembly/TestDAP_breakpointAssembly.py index 15d2305acd694..8bccc2bcf4156 100644 --- a/lldb/test/API/tools/lldb-dap/breakpoint-assembly/TestDAP_breakpointAssembly.py +++ b/lldb/test/API/tools/lldb-dap/breakpoint-assembly/TestDAP_breakpointAssembly.py @@ -8,8 +8,10 @@ import lldbdap_testcase -# @skipIfWindows class TestDAP_setBreakpointsAssembly(lldbdap_testcase.DAPTestCaseBase): + # When using PDB, we need to have debug information to break on assembly_func, + # but this test relies on us not having debug information for that function. + @skipIfWindows def test_can_break_in_source_references(self): """Tests hitting assembly source breakpoints""" program = self.getBuildArtifact("a.out") _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
