ashgti wrote:

Looks like all the tests are passing on linux and for me locally as well.

> The only thing I don't like is that the configurationDone is now once again 
> implicit. In a future PR, I'd love to move the tests to a model where we 
> specify that explicitly after doing the breakpoints (and automatically catch 
> cases where someone forgets, like your PR from earlier this week). I'm happy 
> to sign myself up to do that work.

That sounds great! I think that would help clean up the tests a bit by making 
it a bit more explicit about when they're done configuring things.


https://github.com/llvm/llvm-project/pull/140331
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to