https://github.com/DavidSpickett commented:

Looks OK in isolation, a bit like looking at a TableGen backend, easier to 
judge the output than the emitters.

Please look over the FIXMEs and see if anything can be done right now, I 
highlighted one that is potentially a problem but the rest don't seem 
important. See if you agree.

Also please remove any that are no longer relevant.

https://github.com/llvm/llvm-project/pull/138032
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to