================
@@ -67,7 +67,9 @@ TypeFilterImpl::FrontEnd::GetIndexOfChildWithName(ConstString 
name) {
       }
     }
   }
-  return UINT32_MAX;
+  return llvm::createStringError(
+      "'SyntheticChildrenFrontEnd::FrontEnd' cannot find index of child '%s'",
----------------
adrian-prantl wrote:

> Adding logging to all these places feels a bit noisy.

Currently the error is dropped silently. You wouldn't replace that with adding 
logging everywhere. My suggestion would be to:
- return errors that are understandable to users
- where necessary add logging in the error case with additional information

https://github.com/llvm/llvm-project/pull/136693
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to