================
@@ -42,10 +43,19 @@ SourceRequestHandler::Run(const protocol::SourceArguments
&args) const {
if (!frame.IsValid())
return llvm::make_error<DAPError>("source not found");
- lldb::SBInstructionList insts =
frame.GetSymbol().GetInstructions(dap.target);
lldb::SBStream stream;
lldb::SBExecutionContext exe_ctx(frame);
- insts.GetDescription(stream, exe_ctx);
+ lldb::SBSymbol symbol = frame.GetSymbol();
+
+ if (symbol.IsValid()) {
+ lldb::SBInstructionList insts = symbol.GetInstructions(dap.target);
+ insts.GetDescription(stream, exe_ctx);
+ } else {
+ // No valid symbol, just return the disassembly
----------------
JDevlieghere wrote:
```suggestion
// No valid symbol, just return the disassembly.
```
[When writing comments, write them as English prose, using proper
capitalization, punctuation,
etc.](https://llvm.org/docs/CodingStandards.html#commenting)
https://github.com/llvm/llvm-project/pull/136777
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
