Author: Michael Buch Date: 2025-04-23T16:27:23+01:00 New Revision: 96519028d514853d429c2d09482ba0bd9a899c57
URL: https://github.com/llvm/llvm-project/commit/96519028d514853d429c2d09482ba0bd9a899c57 DIFF: https://github.com/llvm/llvm-project/commit/96519028d514853d429c2d09482ba0bd9a899c57.diff LOG: [lldb][DataFormatters] Make data-formatters log to the DataFormatters channel Currently the data-formatters log to either DataFormatters or Types. The former is probably more sensible, so log there consistently from all formatters. Added: Modified: lldb/source/Plugins/Language/CPlusPlus/LibCxxInitializerList.cpp lldb/source/Plugins/Language/CPlusPlus/LibCxxSpan.cpp lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxxInitializerList.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibCxxInitializerList.cpp index ffc894256626c..f0675da1eac9f 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/LibCxxInitializerList.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/LibCxxInitializerList.cpp @@ -90,7 +90,8 @@ lldb_private::formatters::LibcxxInitializerListSyntheticFrontEnd::Update() { llvm::Expected<uint64_t> size_or_err = m_element_type.GetByteSize(nullptr); if (!size_or_err) - LLDB_LOG_ERRORV(GetLog(LLDBLog::Types), size_or_err.takeError(), "{0}"); + LLDB_LOG_ERRORV(GetLog(LLDBLog::DataFormatters), size_or_err.takeError(), + "{0}"); else { m_element_size = *size_or_err; // Store raw pointers or end up with a circular dependency. diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxxSpan.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibCxxSpan.cpp index acda41024cf03..cfb42e283f828 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/LibCxxSpan.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/LibCxxSpan.cpp @@ -104,7 +104,8 @@ lldb_private::formatters::LibcxxStdSpanSyntheticFrontEnd::Update() { // Get element size. llvm::Expected<uint64_t> size_or_err = m_element_type.GetByteSize(nullptr); if (!size_or_err) - LLDB_LOG_ERRORV(GetLog(LLDBLog::Types), size_or_err.takeError(), "{0}"); + LLDB_LOG_ERRORV(GetLog(LLDBLog::DataFormatters), size_or_err.takeError(), + "{0}"); else { m_element_size = *size_or_err; diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp index 701946d44cb40..82b34584e35a6 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp @@ -99,8 +99,8 @@ LibcxxVariantGetIndexValidity(ValueObjectSP &impl_sp) { llvm::Expected<uint64_t> index_type_bytes = index_type.GetByteSize(nullptr); if (!index_type_bytes) { - LLDB_LOG_ERRORV(GetLog(LLDBLog::Types), index_type_bytes.takeError(), - "{0}"); + LLDB_LOG_ERRORV(GetLog(LLDBLog::DataFormatters), + index_type_bytes.takeError(), "{0}"); if (!index_type_bytes) return LibcxxVariantIndexValidity::Invalid; } diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp index ce2261b6f03c3..900d8d4dce0b5 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp @@ -150,7 +150,8 @@ lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::Update() { m_element_type = data_sp->GetCompilerType().GetPointeeType(); llvm::Expected<uint64_t> size_or_err = m_element_type.GetByteSize(nullptr); if (!size_or_err) - LLDB_LOG_ERRORV(GetLog(LLDBLog::Types), size_or_err.takeError(), "{0}"); + LLDB_LOG_ERRORV(GetLog(LLDBLog::DataFormatters), size_or_err.takeError(), + "{0}"); else { m_element_size = *size_or_err; _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
