tfiala added a comment.
Looks fine to me pending that one question on the TSAN check (i.e. if the
existing TSAN check is as good as your new ASAN check, LGTM).
================
Comment at:
packages/Python/lldbsuite/test/functionalities/tsan/basic/TestTsanBasic.py:23
@skipIfRemote
- @skipUnlessCompilerRt
@skipUnlessThreadSanitizer
def test(self):
----------------
Seems fine as long as @skipUnlessThreadSanitizer is doing the right type of
check like you added for @skipUnlessAddressSanitizer.
https://reviews.llvm.org/D26513
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits