Author: Raul Tambre Date: 2025-04-18T14:48:30+03:00 New Revision: c890b7376fc916c1818dc3c211a080601973aa0b
URL: https://github.com/llvm/llvm-project/commit/c890b7376fc916c1818dc3c211a080601973aa0b DIFF: https://github.com/llvm/llvm-project/commit/c890b7376fc916c1818dc3c211a080601973aa0b.diff LOG: [lldb][Telemetry] Fix unit test compile failure with LLVM_ENABLE_TELEMETRY=0 (#136115) It needs to be `TEST_F` to access `received_entries`. Disabling also works based on the test not the fixture name. Build failure: ``` lldb/unittests/Core/TelemetryTest.cpp:110:17: error: use of undeclared identifier 'received_entries' 110 | ASSERT_EQ(1U, received_entries.size()); | ^ lldb/unittests/Core/TelemetryTest.cpp:112:61: error: use of undeclared identifier 'received_entries' 112 | llvm::dyn_cast<lldb_private::FakeTelemetryInfo>(received_entries[0]) | ^ ``` Fixes: 159b872b37363511a359c800bcc9230bb09f2457 Added: Modified: lldb/unittests/Core/TelemetryTest.cpp Removed: ################################################################################ diff --git a/lldb/unittests/Core/TelemetryTest.cpp b/lldb/unittests/Core/TelemetryTest.cpp index 1e41424bac3ce..910149d865c13 100644 --- a/lldb/unittests/Core/TelemetryTest.cpp +++ b/lldb/unittests/Core/TelemetryTest.cpp @@ -96,7 +96,7 @@ class TelemetryTest : public testing::Test { #if LLVM_ENABLE_TELEMETRY #define TELEMETRY_TEST(suite, test) TEST_F(suite, test) #else -#define TELEMETRY_TEST(suite, test) TEST(DISABLED_##suite, test) +#define TELEMETRY_TEST(suite, test) TEST_F(suite, DISABLED_##test) #endif TELEMETRY_TEST(TelemetryTest, PluginTest) { _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
