Author: Vy Nguyen Date: 2025-03-18T10:09:03-04:00 New Revision: ca87823438e312f4fc7f13bda6ced448e4216cf6
URL: https://github.com/llvm/llvm-project/commit/ca87823438e312f4fc7f13bda6ced448e4216cf6 DIFF: https://github.com/llvm/llvm-project/commit/ca87823438e312f4fc7f13bda6ced448e4216cf6.diff LOG: [LLDB][NFC]Refactor common test setup into SetUp method (#131203) Added: Modified: lldb/unittests/Core/TelemetryTest.cpp Removed: ################################################################################ diff --git a/lldb/unittests/Core/TelemetryTest.cpp b/lldb/unittests/Core/TelemetryTest.cpp index 72db8c17f09ea..1e41424bac3ce 100644 --- a/lldb/unittests/Core/TelemetryTest.cpp +++ b/lldb/unittests/Core/TelemetryTest.cpp @@ -81,6 +81,16 @@ using namespace lldb_private::telemetry; class TelemetryTest : public testing::Test { public: lldb_private::SubsystemRAII<lldb_private::FakePlugin> subsystems; + std::vector<std::unique_ptr<::llvm::telemetry::TelemetryInfo>> + received_entries; + + void SetUp() override { + auto *ins = lldb_private::telemetry::TelemetryManager::GetInstance(); + ASSERT_NE(ins, nullptr); + + ins->addDestination( + std::make_unique<lldb_private::TestDestination>(&received_entries)); + } }; #if LLVM_ENABLE_TELEMETRY @@ -90,17 +100,8 @@ class TelemetryTest : public testing::Test { #endif TELEMETRY_TEST(TelemetryTest, PluginTest) { - // This would have been called by the plugin reg in a "real" plugin - // For tests, we just call it directly. - lldb_private::FakePlugin::Initialize(); - - auto *ins = lldb_private::telemetry::TelemetryManager::GetInstance(); - ASSERT_NE(ins, nullptr); - - std::vector<std::unique_ptr<::llvm::telemetry::TelemetryInfo>> - received_entries; - ins->addDestination( - std::make_unique<lldb_private::TestDestination>(&received_entries)); + lldb_private::telemetry::TelemetryManager *ins = + lldb_private::telemetry::TelemetryManager::GetInstance(); lldb_private::FakeTelemetryInfo entry; entry.msg = ""; @@ -115,14 +116,6 @@ TELEMETRY_TEST(TelemetryTest, PluginTest) { } TELEMETRY_TEST(TelemetryTest, ScopedDispatcherTest) { - lldb_private::FakePlugin::Initialize(); - auto *ins = TelemetryManager::GetInstance(); - ASSERT_NE(ins, nullptr); - std::vector<std::unique_ptr<::llvm::telemetry::TelemetryInfo>> - received_entries; - ins->addDestination( - std::make_unique<lldb_private::TestDestination>(&received_entries)); - { ScopedDispatcher<lldb_private::FakeTelemetryInfo> helper( [](lldb_private::FakeTelemetryInfo *info) { info->num = 0; }); _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
