================ @@ -316,6 +316,36 @@ struct Source { bool fromJSON(const llvm::json::Value &, Source &, llvm::json::Path); llvm::json::Value toJSON(const Source &); +// MARK: Events + +// "ExitedEvent": { +// "allOf": [ { "$ref": "#/definitions/Event" }, { +// "type": "object", +// "description": "The event indicates that the debuggee has exited and +// returns its exit code.", "properties": { +// "event": { +// "type": "string", +// "enum": [ "exited" ] +// }, +// "body": { +// "type": "object", +// "properties": { +// "exitCode": { +// "type": "integer", +// "description": "The exit code returned from the debuggee." +// } +// }, +// "required": [ "exitCode" ] +// } +// }, +// "required": [ "event", "body" ] +// }] +// } +struct ExitedEventBody { + int exitCode; ---------------- vogelsgesang wrote:
> To summarize my position: I think having an EventHandler abstraction is > perfectly fine (and even desirable from an abstraction point of view) but I > would encourage implementing it through a direct call instead. @JDevlieghere Could you elaborate on how the "perfect" design would look in you opinion? I currently fail to imagine the combination of "direct call" with "EventHandler abstraction" / "base class" https://github.com/llvm/llvm-project/pull/130104 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits