================
@@ -173,12 +184,13 @@ RequestHandler::LaunchProcess(const llvm::json::Object
&request) const {
auto flags = launch_info.GetLaunchFlags();
- if (GetBoolean(arguments, "disableASLR").value_or(true))
- flags |= lldb::eLaunchFlagDisableASLR;
- if (GetBoolean(arguments, "disableSTDIO").value_or(false))
- flags |= lldb::eLaunchFlagDisableSTDIO;
- if (GetBoolean(arguments, "shellExpandArguments").value_or(false))
- flags |= lldb::eLaunchFlagShellExpandArguments;
+ flags = SetLaunchFlag(flags, arguments, "disableASLR",
+ lldb::eLaunchFlagDisableASLR, true);
+ flags = SetLaunchFlag(flags, arguments, "disableSTDIO",
+ lldb::eLaunchFlagDisableSTDIO, false);
+ flags = SetLaunchFlag(flags, arguments, "shellExpandArguments",
+ lldb::eLaunchFlagShellExpandArguments, false);
----------------
JDevlieghere wrote:
```suggestion
flags = SetLaunchFlag(flags, arguments, "disableASLR",
lldb::eLaunchFlagDisableASLR);
flags = SetLaunchFlag(flags, arguments, "disableSTDIO",
lldb::eLaunchFlagDisableSTDIO);
flags = SetLaunchFlag(flags, arguments, "shellExpandArguments",
lldb::eLaunchFlagShellExpandArguments);
```
https://github.com/llvm/llvm-project/pull/129753
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
