llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) <details> <summary>Changes</summary> The existing implementation would probably produce false positives for discontinuous functions. I haven't tried reproducing it because setting up discontinuous functions (and executing them, in particular) is pretty complex and there's nothing particularly interesting happening here. --- Full diff: https://github.com/llvm/llvm-project/pull/128515.diff 1 Files Affected: - (modified) lldb/source/Target/ThreadPlanStepRange.cpp (+5-3) ``````````diff diff --git a/lldb/source/Target/ThreadPlanStepRange.cpp b/lldb/source/Target/ThreadPlanStepRange.cpp index de4cd5995f695..78e1270edcdab 100644 --- a/lldb/source/Target/ThreadPlanStepRange.cpp +++ b/lldb/source/Target/ThreadPlanStepRange.cpp @@ -197,9 +197,11 @@ bool ThreadPlanStepRange::InRange() { bool ThreadPlanStepRange::InSymbol() { lldb::addr_t cur_pc = GetThread().GetRegisterContext()->GetPC(); if (m_addr_context.function != nullptr) { - return m_addr_context.function->GetAddressRange().ContainsLoadAddress( - cur_pc, &GetTarget()); - } else if (m_addr_context.symbol && m_addr_context.symbol->ValueIsAddress()) { + AddressRange unused_range; + return m_addr_context.function->GetRangeContainingLoadAddress( + cur_pc, GetTarget(), unused_range); + } + if (m_addr_context.symbol && m_addr_context.symbol->ValueIsAddress()) { AddressRange range(m_addr_context.symbol->GetAddressRef(), m_addr_context.symbol->GetByteSize()); return range.ContainsLoadAddress(cur_pc, &GetTarget()); `````````` </details> https://github.com/llvm/llvm-project/pull/128515 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
