cmtice wrote: I've addressed most of the review comments now. I have not done the format_provider requests (waiting for response to questions) nor the bit about the DIagnosticManager. I haven't removed the code to look up global variables, but I think I may have fixed the main objection (it now uses StackFrame::GetInScopeVariableList rather than FindGlobalVariables).
https://github.com/llvm/llvm-project/pull/120971 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
