labath added inline comments.

================
Comment at: packages/Python/lldbsuite/test/dotest.py:484
 
+    os.environ['LLDB_CODESIGN_IDENTITY'] = args.codesign_identity
+
----------------
The function is not really consistent in this aspect, but if you don't really 
need this to be in the environment, maybe exporting it as a variable in 
`lldbtest_config` would be cleaner (see args.channels above for an example)?


https://reviews.llvm.org/D25714



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to