JDevlieghere wrote: - This isn't using `TINFO_LIBRARIES` anywhere. Presumably you'll need to add it to `LLDB_CURSES_LIBS` like the original spack patch. - This doesn't work on systems that have `ncruses` and `panel`, but no separate `terminfo` library. The purpose of the CMake module is to find `ncurses` and `panel` as a unit, and we don't want to fail if `terminfo` is part of `ncurses`, which is what happens with the current patch. I don't know if there's a way to set optional variables through (at least not at first glance), in which case we might need to auto-detect it with `add_optional_dependency` and a separate module for finding it. The auto-detection should make that work out of the box on all platforms and platforms that know they need `terminfo` can set the CMake flag to "on" to force a configuration time warning if it's not found.
https://github.com/llvm/llvm-project/pull/126810 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
