================
@@ -110,8 +110,8 @@ 
NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
 
 NativeRegisterContextWindows_x86_64::NativeRegisterContextWindows_x86_64(
     const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-    : NativeRegisterContextWindows(native_thread,
-                                   CreateRegisterInfoInterface(target_arch)) {}
+    : NativeRegisterContextRegisterInfo(
+          native_thread, CreateRegisterInfoInterface(target_arch)) {}
----------------
omjavaid wrote:

Yes. Correct.
NativeRegisterContextWindows_arm64 class now inherits from both 
NativeRegisterContextWindows and NativeRegisterContextDBReg_arm64 but both of 
these classes previously inherited from NativeRegisterContextRegisterInfo 
non-virtually. This caused multiple instances of 
NativeRegisterContextRegisterInfo in the hierarchy.
I have now changed NativeRegisterContextWindows definition to inherit 
NativeRegisterContextRegisterInfo virtually 
which shifts the responsibility of initializing 
NativeRegisterContextRegisterInfo to the most derived class.
Thats why this and other similar changes have been made.

https://github.com/llvm/llvm-project/pull/108072
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to