https://github.com/jimingham approved this pull request.
LGTM. It was silly to remove the section information from the Address only to have the Breakpoint have to find it again. The only potentially concerning change here is the removal of a check for when you go to set the breakpoint and the Address you got for the Symbol was not yet loaded into the process you are debugging (at removed lines 241-2). You could easily put that check back in but that was not necessary in the original code, since you only setup the breakpoint after you see the RuntimeModule get loaded; and it's doubly unnecessary now since you switched to setting the breakpoint with an Address gotten from a module, so it will track the correct load address even if set before the load. https://github.com/llvm/llvm-project/pull/94794 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
