https://github.com/labath commented:

Marking a file as being generated by lldb makes sense, but given that there's 
no way (is there?) to reserve a flag bit for lldb, and the flag bits are a 
relatively scarce commodity (there's 64 of them total, how many are free right 
now?).

What would you say to creating a new "CreatedByLLDB" stream type and using that 
as the marker? There are 4 billion stream types, so the danger of collision is 
much lower, and we also have ample precedent for creating custom stream types. 
The thing I like about that is the we can then also insert additional metadata 
about the minidump into the stream, for example, whether it includes a linker 
rendezvous structures, which I think is the important part here (I'm not saying 
you have to do that now -- we can start out with a completely empty stream -- 
but I like how this gives us an option to do that in the future).

https://github.com/llvm/llvm-project/pull/120166
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to