ZequanWu wrote: > if you're sending things for presubmit checks, but not for precommit review, > please include the `skip-precommit-approval` label
Good to know that. > - but in this case it looks like you requested review, but then submitted > without waiting for that review? Please don't do that, per: > https://llvm.org/docs/CodeReview.html#code-review-workflow > > > Specifically, once a patch is sent out for review, it needs an explicit > > approval before it is committed. Okay, I should just commit directly for this kind of relanding. https://github.com/llvm/llvm-project/pull/117071 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
