Author: Dmitry Vasilyev Date: 2024-11-14T11:28:17+04:00 New Revision: 3d3b0bc239cd9c6e8c65ae26bdcf1534515c4beb
URL: https://github.com/llvm/llvm-project/commit/3d3b0bc239cd9c6e8c65ae26bdcf1534515c4beb DIFF: https://github.com/llvm/llvm-project/commit/3d3b0bc239cd9c6e8c65ae26bdcf1534515c4beb.diff LOG: [lldb] Disable find-module.test in case of a remote target (#94165) The target arch is `i386-pc-windows` after loading the dump. It updates to `i386-pc-windows-msvc` or `i386-pc-windows-gnu` in lldb\source\Plugins\Process\minidump\ProcessMinidump.cpp, line 218 ``` GetTarget().MergeArchitecture(module->GetArchitecture()); ``` But in case of the remote target (`remote-linux`) and the `Windows host` lldb executed the following commands at the beginning ``` platform select remote-linux platform connect connect://<ip>:<port> ``` and then the target arch is `i386-pc-windows-msvc` immediately after loading the dump. GetTarget().MergeArchitecture(module->GetArchitecture()) does not update it to `i386-pc-windows-gnu` when the module arch is `i386-pc-windows-gnu`. --------- Co-authored-by: Pavel Labath <pa...@labath.sk> Added: Modified: lldb/test/Shell/Minidump/Windows/find-module.test Removed: ################################################################################ diff --git a/lldb/test/Shell/Minidump/Windows/find-module.test b/lldb/test/Shell/Minidump/Windows/find-module.test index 7ac2f74f8039b1..fe457f4123522f 100644 --- a/lldb/test/Shell/Minidump/Windows/find-module.test +++ b/lldb/test/Shell/Minidump/Windows/find-module.test @@ -1,6 +1,8 @@ Test that we correctly find a PE/COFF file in our executable search path, and use it when opening minidumps. +XFAIL: remote{{.*}} + RUN: yaml2obj %S/Inputs/find-module.exe.yaml -o %T/find-module.exe RUN: yaml2obj %S/Inputs/find-module.dmp.yaml -o %T/find-module.dmp RUN: %lldb -O "settings set target.exec-search-paths %T" \ _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
