labath wrote: I don't think we should submit this, because I believe this file exists only as a consequence of shoehorning NativeProcessAIX into the NativeProcessLinux mould. I think this needs to be reviewed in conjunction with the rest of the process code using it. If you want to start reviewing NativeProcessAIX, then I'd suggest you create a PR for that, and include this file in that PR. Looking over the file again, I'm fairly certain we won't be trying to make a common linux+aix base class (though we may want to move some parts into a common helper function/class), so you don't have to create a diff-with-linux PR (not on my account at least), and you can create the PR as you would want the final checked in form to look.
The reason I suggested moving this to the Process tree is so that we could punt on this file for now -- my assumption was that you want to deal with the changes in the Host folder first (I see you still have a fair number of those), as those would be required to get a functional process plugin. If they're not, and you want to do the process plugin first, then be my guest. https://github.com/llvm/llvm-project/pull/108000 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
