================ @@ -1465,11 +1462,7 @@ CreateRunInTerminalReverseRequest(const llvm::json::Object &launch_request, llvm::StringRef key = envs.GetNameAtIndex(index); llvm::StringRef value = envs.GetValueAtIndex(index); - if (key.empty()) - g_dap.SendOutput(OutputType::Stderr, - "empty environment variable for value: \"" + - value.str() + '\"'); - else ---------------- ashgti wrote:
I guess I wasn't really sure why this is a warning. In lldb I can use `settings set target.env-vars FOO=` and there isn't any warnings when I run a process and having an empty env isn't an issue on mac or linux as far as I can tell. I also don't see any mentions of why this was added in github.com/llvm/llvm-project/pull/106919 I could move the warning into lldb-dap.cpp after we call this helper. https://github.com/llvm/llvm-project/pull/115561 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits