Author: Michael Buch Date: 2024-10-19T10:07:57+01:00 New Revision: faed85b8e4961e853bfb10cd8ed1544e179ade0a
URL: https://github.com/llvm/llvm-project/commit/faed85b8e4961e853bfb10cd8ed1544e179ade0a DIFF: https://github.com/llvm/llvm-project/commit/faed85b8e4961e853bfb10cd8ed1544e179ade0a.diff LOG: [lldb][test][NFC] Document DYLIB_NAME Makefile variable (#112735) Got caught out by this because simply specifying `DYLIB_CXX_SOURCES` (without specifying `DYLIB_NAME`) resulted in linker errors because the dylib was never built (and linked). We should probably make that a Makefile error (though I haven't audited when exactly not specifying `DYLIB_NAME` is valid; looked like that can happen when we specify `FRAMEWORK`). Added: Modified: lldb/packages/Python/lldbsuite/test/make/Makefile.rules Removed: ################################################################################ diff --git a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules index f81db9bc06d8a8..d0045ac9f91a77 100644 --- a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules +++ b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules @@ -13,6 +13,13 @@ # the building of the a.out executable program. For example, # DYLIB_ONLY := YES # +# When specifying one of the DYLIB_*_SOURCES variables, DYLIB_NAME +# controls the (platform-dependent) name of the produced dylib. E.g., +# on Darwin, if "DYLIB_NAME := foo", the generated dylib will be called +# "libfoo.dylib". +# +# DYLIB_NAME := foo +# # Specifying FRAMEWORK and its variants has the effect of building a NeXT-style # framework. # FRAMEWORK := "Foo" _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
