labath wrote:

Fixing definitely. Jacob, please change this to a hex constant and put the 
string in the comment. The name of the constants also seems out of place here. 
All of the other constants (even those that wrap existing windows ALL_CAPS) 
constants are using CamelCase). I'd suggest `enum class ExceptionFlag : uint32 
{ LLDB = 0xdead };`

https://github.com/llvm/llvm-project/pull/108448
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to