jimingham wrote:
> On Oct 10, 2024, at 4:14 PM, Alex Langford ***@***.***> wrote: > > > My mental model is that everything in lldb-enumerations.h should be public > and all the private enumerations should go in lldb-private-enumerations.h. In > practice I think there are tons of things in lldb-enumerations.h that should > not be public at all, but I'm not sure which are safe to remove since they're > all exposed through the Python bindings. > I agree with that, but the argument here was going the other way. lldb-enumerations.h are a base set of enumerations that anybody using LLDB, either lldb_private or the SB API's are free to use. But the SB API's are purely wrappers around lldb_private API's, and so should never be used in lldb_private. If you put an SB API header in lldb-enumerations.h, now most of lldb_private is going to see it. Does that also fit wth your mental model? Jim > — > Reply to this email directly, view it on GitHub > <https://github.com/llvm/llvm-project/pull/111907#issuecomment-2406197265>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADUPVW4MGWXIYXXUTNNN6NTZ24C3RAVCNFSM6AAAAABPXQYNLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBWGE4TOMRWGU>. > You are receiving this because you were mentioned. > https://github.com/llvm/llvm-project/pull/111907 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
