jeffreytan81 wrote:

> > I think we can do better than save at memory region fidelity which is at 
> > least at page boundary if I am not wrong.
> 
> > We can use type information to query and save the object's size without 
> > including hundreds of unrelated objects in the
> > heap happen to be in the same page. This should greatly reduce the size of 
> > the dump.
> 
> I'm okay with this, when @clayborg and I talked about this the original 
> assumption is we should do the entire memory region it's in, because with 
> deduplication we will likely get multiple pointers to the same heap. I think 
> we should leave this heap-region mode, and then also build a 'just save my 
> objects' extension.

The value of this option lies in reducing the size to a minimum while retaining 
useful information. In such cases, saving object closures is a superior choice 
compared to saving memory regions. You can easily achieve minidumps that are 2 
to 3 times smaller in some cases. 

https://github.com/llvm/llvm-project/pull/111601
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to