llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Stefan Gränitz (weliveindetail) <details> <summary>Changes</summary> Around 400 of LLDB's dotest.py based tests require the `make` tool to be found in Path. If it's not found, they fail with an obscure error and show up as `UNRESOLVED`. llvm-lit takes care of MSYS based testing tools like cat, printf, etc., but make is not part of that. Let's catch the situation early and raise an error if LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS was enabled. This error is not fatal: It should fail the build, but not immediately stop the configuration process. There might be other issues further down the line that can be caught in the same buildbot run. --- Full diff: https://github.com/llvm/llvm-project/pull/111531.diff 1 Files Affected: - (modified) lldb/test/CMakeLists.txt (+12) ``````````diff diff --git a/lldb/test/CMakeLists.txt b/lldb/test/CMakeLists.txt index 5ac474736eb63d..7993be2602e538 100644 --- a/lldb/test/CMakeLists.txt +++ b/lldb/test/CMakeLists.txt @@ -29,6 +29,18 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS) "`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`") endif() endforeach() + + # On Windows make is not part of the MSYS tools that llvm-lit takes care of + find_program(MAKE_TOOL make) + if(MAKE_TOOL) + message(STATUS "Found make: ${MAKE_TOOL}") + else() + message(STATUS "Not found: make") + message(SEND_ERROR + "LLDB tests require 'make' tool. Please install and add it to Path " + "(or otherwise disable strict testing requirements with " + "`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`)") + endif() endif() if(LLDB_BUILT_STANDALONE) `````````` </details> https://github.com/llvm/llvm-project/pull/111531 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
