labath wrote: > > Seems reasonable, but you'll need to use the signal constants from > > `UnixSignals` (looked up by string), as macros like `SIGBUS` might not > > exist (windows) or might not have the right value (macos). > > (NativeThreadLinux can get away with using them as it always runs on the > > host.) > > You're referring to the properties in the ELFSignal object?
I'm referring to all of the places where you have `case SIGSOMETHING` in this patch. That's not good because the constant comes from the host, and it may be defined differently on the target. (or not defined at all). https://github.com/llvm/llvm-project/pull/110065 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
